Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add CLI, gRPC, MsgServer tests #1405

Merged
merged 14 commits into from
Jun 25, 2024
Merged

test: add CLI, gRPC, MsgServer tests #1405

merged 14 commits into from
Jun 25, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 31, 2024

Description

closes: #XXXX

Test coverage reached over 80%

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 36 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (7bd6c82) to head (201dc20).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
+ Coverage   69.63%   70.62%   +0.99%     
==========================================
  Files         751      753       +2     
  Lines       61854    61892      +38     
==========================================
+ Hits        43069    43711     +642     
+ Misses      16154    15516     -638     
- Partials     2631     2665      +34     
Files Coverage Δ
x/fbridge/client/cli/query.go 78.43% <100.00%> (+78.43%) ⬆️
x/fbridge/client/cli/tx.go 93.27% <100.00%> (+93.27%) ⬆️
x/fbridge/keeper/auth.go 88.23% <0.00%> (+30.39%) ⬆️
testutil/cli/tm_mocks.go 0.00% <0.00%> (ø)
types/module/testutil/codec.go 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@tkxkd0159 tkxkd0159 force-pushed the fbridge-integration-test branch from 2028087 to 00340b8 Compare May 31, 2024 08:45
@tkxkd0159 tkxkd0159 force-pushed the fbridge-integration-test branch from 9997642 to d87cdac Compare June 20, 2024 05:05
@tkxkd0159 tkxkd0159 marked this pull request as ready for review June 25, 2024 00:59
@tkxkd0159 tkxkd0159 requested a review from 170210 June 25, 2024 00:59
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkxkd0159 tkxkd0159 merged commit 97219d5 into main Jun 25, 2024
37 of 38 checks passed
@tkxkd0159 tkxkd0159 deleted the fbridge-integration-test branch June 25, 2024 12:51
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
* Add global test codec

* Add TransferTxCmd test

* Add the remaining tx cli tests

* Add cli query test

* Add fbridge auth test case

* Add grpc-query test

* Add msg server tests

* Add type tests

* Add CHANGELOG

(cherry picked from commit 97219d5)

# Conflicts:
#	CHANGELOG.md
tkxkd0159 added a commit that referenced this pull request Jun 26, 2024
(cherry picked from commit 97219d5)

* Add CHANGELOG

* Resolve ostracon conflicts

---------

Co-authored-by: Jaeseung Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants